-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address build failures #367
Conversation
Several classes in core were moved to another package causing builds to fail. Signed-off-by: MaxKsyunz <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #367 +/- ##
============================================
- Coverage 73.30% 73.27% -0.04%
- Complexity 698 699 +1
============================================
Files 110 110
Lines 4612 4614 +2
Branches 606 608 +2
============================================
Hits 3381 3381
Misses 980 980
- Partials 251 253 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thank you @MaxKsyunz ! |
@peternied @lezzago could you label this PR with backport to 2.x? Now that XContent refactor is in OpenSearch 2.x, common-utils 2.x build fails. I confirmed locally that backporting these changes is sufficient to make it build again. |
@MaxKsyunz Looks like this is addressed in #392 |
Xcontent classes were moved in this PR opensearch-project/OpenSearch#5902 causing builds to fail.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.